-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final token updates #12754
Final token updates #12754
Conversation
Build Artifacts
|
// palette.red.v_300 but at the same time, | ||
// palette.red.v_300 is the darkest available red | ||
// palette.red.v_600 but at the same time, | ||
// palette.red.v_600 is the darkest available red | ||
// in the palette. Using this hardcoded color was | ||
// agreed with designers. | ||
':hover': { 'background-color': '#A81700' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a follow up issue to look for hard coded colours like this, and instead use the darken utilities in develop?
@@ -115,7 +115,7 @@ | |||
}, | |||
linkStyle() { | |||
const hoverBg = this.isFullscreen | |||
? this.$themeBrand.secondary.v_300 | |||
? this.$themeBrand.secondary.v_600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up from: #12742 (comment)
@@ -63,7 +63,7 @@ | |||
return { | |||
color: this.$themeTokens.text, | |||
':hover': { | |||
'background-color': this.$themeBrand.secondary.v_300, | |||
'background-color': this.$themeBrand.secondary.v_600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up from: #12742 (comment)
@@ -69,7 +69,7 @@ | |||
iconStyle() { | |||
if (this.hasSuperAdminPermission) { | |||
return { | |||
fill: this.lightIcon ? this.$themePalette.yellow.v_400 : this.$themeTokens.superAdmin, | |||
fill: this.lightIcon ? this.$themePalette.yellow.v_200 : this.$themeTokens.superAdmin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct mapping.
@@ -9,7 +9,7 @@ | |||
</div> | |||
<div | |||
class="progress-bar-wrapper" | |||
:style="{ backgroundColor: $themePalette.grey.v_200 }" | |||
:style="{ backgroundColor: $themePalette.grey.v_300 }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct mapping.
@@ -42,7 +42,7 @@ | |||
return this.$computedClass({ | |||
':focus': this.$coreOutline, | |||
':hover': { | |||
backgroundColor: this.$themePalette.blue.v_200, | |||
backgroundColor: this.$themePalette.blue.v_100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct mapping.
@@ -341,10 +341,10 @@ | |||
cancelStyleOverrides() { | |||
return { | |||
color: this.$themeTokens.textInverted, | |||
'background-color': this.$themePalette.red.v_300, | |||
'background-color': this.$themePalette.red.v_600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up from: #12742 (comment)
@@ -3,7 +3,7 @@ | |||
<div | |||
v-show="userDevicesUsingIE11" | |||
class="alert" | |||
:style="{ backgroundColor: $themePalette.yellow.v_200 }" | |||
:style="{ backgroundColor: $themePalette.yellow.v_100 }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up from here: #12742 (comment)
@@ -98,7 +98,7 @@ | |||
return this.$computedClass({ | |||
':focus': this.$coreOutline, | |||
':hover': { | |||
backgroundColor: this.$themePalette.blue.v_200, | |||
backgroundColor: this.$themePalette.blue.v_100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct mapping.
ecbd748
into
learningequality:release-v0.17.x
Summary
Resolves 3 outstanding categories of issues from the KDS upgrade:
References
Please see the first PR and the follow up comments for more details #12742
Reviewer guidance
Manual checks to confirm all is well:
KDateRange
component. Are there any regressions? (This is what tipped me off to the second package.json needing updating.)Testing checklist
PR process
Reviewer checklist
yarn
andpip
)